[test] Restore the t command
#40430
Merged
[test] Restore the t command
#40430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40430--material-ui.netlify.app/ Bundle size report |
Janpot
reviewed
Jan 4, 2024
| @@ -0,0 +1,15 @@ | |||
| import { spawn } from 'node:child_process'; | |||
|
|
|||
There was a problem hiding this comment.
Can you comment here and link to this PR (#40430)? We would likely never have set it up this way if we had started out with pnpm and so that makes the why documented for future generations.
Another thing we could do at some point is add some output saying "pnpm t <pattern> is deprecated, use pnpm tw <pattern> instead. This way of running the tests will be removed in a future version of the MUI core repository". This gives contributors enough time to adapt their muscle memory and us the option of removing the complexity of this script in the future.
Janpot
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restores the pre-pnpm behavior of the
tscript.With yarn, it was possible to run the test CLI by executing
yarn t <test-pattern>. However, pnpm treatstas an alias fortest. I introduced a small script that's run wheneverpnpm torpnpm testis executed. It checks if it has any arguments and calls either the test CLI (previousyarn t) or the extended validation suite (previouslyyarn test)