-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix 301 link to Base UI #40396
[docs] Fix 301 link to Base UI #40396
Conversation
5ac4ca5
to
602757c
Compare
Netlify deploy previewhttps://deploy-preview-40396--material-ui.netlify.app/ Bundle size report |
Just to add some information, you can search props in the algolia, and the link will let you bring you exactly on the props definition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@alexfauquette The only thing I would change here is the labels, making it clear that it's an API page: new (❌): ![]() vs. old (✅): ![]() |
Not the cleanest solution but it works to solve
https://app.ahrefs.com/site-audit/3524616/99/data-explorer?columns=pageRating%2Curl%2Ctraffic%2ChttpCode%2CredirectChainUrls%2CisRedirectLoop%2CincomingAllLinks%2CincomingRedirect%2Corigin&filterId=808b08e88c934ee19e04fdec4ed87a5a&issueId=c64d12c1-d0f4-11e7-8ed1-001e67ed4656&sorting=-pageRating
Extracted in #40531
Off-topic. When it comes to my own use of the components, the UX before #35938 likely work better with my workflows. Now, some would clearly prefer the new UX. Still, I think that it means that for the new approach to have a higher chance of winning, we have to fill the gaps with the older one:
material-ui/docs/translations/translations.json
Line 305 in 48251ab
Off-topic
Extracted in #40532
@alexfauquette I wonder if it would make sense to format more the HTML of the API pages, with h4, h3 so Google can more easily return relevant search results.
I have tried searching for the description of props on Google, can't really find helpful results. Maybe it's not a common workflow though, I don't recall ever trying this in the past as a user.