Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-next][Slider] Replace lodash with internal utils #40261

Merged
merged 1 commit into from
Dec 27, 2023
Merged

[material-next][Slider] Replace lodash with internal utils #40261

merged 1 commit into from
Dec 27, 2023

Conversation

DiegoAndai
Copy link
Member

Replace lodash's debounce and isEqual with internal utils in useSliderElementsOverlap. With this we avoid adding lodash as a dependency.

@DiegoAndai DiegoAndai added component: select This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature labels Dec 20, 2023
@DiegoAndai DiegoAndai self-assigned this Dec 20, 2023
@mui-bot
Copy link

mui-bot commented Dec 20, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-40261--material-ui.netlify.app/

@mui/material-next: parsed: -18.38% 😍, gzip: -21.18% 😍

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 811fcc9

mj12albert
mj12albert approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@mj12albert mj12albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mj12albert mj12albert merged commit e2c3884 into mui:master Dec 27, 2023
8 checks passed
@DiegoAndai DiegoAndai deleted the replace-lodash-mn-slider branch December 27, 2023 13:00
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
@DiegoAndai @mnajdova
[material-next][Slider] Replace lodash with internal utils (mui#40261)
1e8f9ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mj12albert mj12albert mj12albert approved these changes

Assignees

@DiegoAndai DiegoAndai

Labels
component: select This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DiegoAndai @mui-bot @mj12albert