Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Fix link to charts getting started page #40043

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

alexfauquette
Copy link
Member

Fix link broken in mui/mui-x#11239

@alexfauquette alexfauquette added the website Pages that are not documentation-related, marketing-focused. label Nov 30, 2023
@mui-bot
Copy link

mui-bot commented Nov 30, 2023

Netlify deploy preview

https://deploy-preview-40043--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e0384f8

docs/pages/blog/mui-x-end-v6-features.md Outdated Show resolved Hide resolved
@danilo-leal danilo-leal added blog MUI X and removed website Pages that are not documentation-related, marketing-focused. labels Nov 30, 2023
Signed-off-by: Danilo Leal <[email protected]>
@danilo-leal danilo-leal merged commit 8d733c7 into mui:master Nov 30, 2023
6 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 30, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 30, 2023

To revert no? It looks like it was correct before. It won't be correct until MUI X v7 is released as stable.

@alexfauquette
Copy link
Member Author

To revert no? It looks like it was correct before. It won't be correct until MUI X v7 is released as stable.

It will be correct when X deploys its docs (tomorrow). Such that:

  • Between X deploy and core deploy: the link exists but the has is missing
  • After core deployment: everything is fine

@oliviertassinari
Copy link
Member

Oh, ok, we cherry-picked changes to v6 https://github.com/mui/mui-x/commits/master. I had assumed the strategy was all-in into v7.

@alexfauquette
Copy link
Member Author

I had assumed the strategy was all-in into v7

For charts as long as the effort is not too important, I backport changes, especially for docs, such that people discovering the package can get the best we can offer without having to go on the alpha

mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 1, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 1, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants