-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Slider] Fix customized iOS demo to use updated official colors #39813
Conversation
Netlify deploy previewhttps://deploy-preview-39813--material-ui.netlify.app/ Bundle size report |
Since it's the |
@@ -34,7 +34,7 @@ const marks = [ | |||
]; | |||
|
|||
const IOSSlider = styled(Slider)(({ theme }) => ({ | |||
color: theme.palette.mode === 'dark' ? '#3880ff' : '#3880ff', | |||
color: theme.palette.mode === 'dark' ? '#419dfe' : '#0141dd', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the Apple Design Figma kit, the current colors are these:
color: theme.palette.mode === 'dark' ? '#419dfe' : '#0141dd', | |
color: theme.palette.mode === 'dark' ? '#0A84FF' : '#007AFF', |
Hey @Super-Kenil thanks for the submission! I wonder if we shouldn't use this chance to update the visual to look more like the current iOS version: |
I think I can make it look the current version, just like you mentioned. I will update it and commit. But I am still facing issues related to passing one of the checks of Argos |
👍👍👍 @Super-Kenil Don't worry about the argos check! Sometimes it can be very flaky, it can literally be the very last thing we deal with for this PR 😬 |
I know this is not the right place @mj12albert @zanivan , but I am trying to contribute to the docs, and I am facing issue when I started the dev server on my machine, I tried to fix it myself, but I surely am missing something. This is my first time contributing anywhere, so any help would be appreciated. Checkout the attached image, it shows the error I am getting. |
@Super-Kenil Hey, could you push your latest commits to this branch, even if there are errors? I can check out your branch and have a look |
@mj12albert , I did it, you can have a look there. And yes, the project didn't start even when I had not made any changes, so there must be something I am missing as this is my first ever contribution |
@Super-Kenil You've done I don't see anything wrong with your branch btw, it runs fine for me 🤔 |
@mj12albert Then I will try again with latest version of yarn today, and make changes, thanks for letting me know about yarn thing. |
@Super-Kenil Any updates on this? |
@ZeeshanTamboli , I have been busy lately with my new nextjs project, which I will be finishing up in soon, So. I will be updating the design very soon |
The iOS slider has been updated to latest design just like @zanivan mentioned |
@mj12albert can you tell me, exactly which yarn version are you using, cause I have been facing same errors even after updating to yarn latest like you mentioned with the following guide . I don't get those errors when I visit any components page, I am able to visit all pages other pages, where it doesn't contain examples. If possible then guide me as well, although the design has be done, and the PR is ready to get merged, but I can help in future too if at least I will be able to install the dependencies. |
Signed-off-by: Kenil Sudani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, appreciate it! (Though I might fine-tune this a bit further on an upcoming Slider revision page). 😬 But we should get this one out of the door already!
… colors (mui#39813) Signed-off-by: Kenil Sudani <[email protected]>
New Changes: I have updated iOSlider's design as per apple's docs
Old changes: I removed the unnecessary condition which was returning the same value, regardless if the condition is true or false.
👉 https://deploy-preview-39813--material-ui.netlify.app/material-ui/react-slider/#customization