Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joy-ui][Accordion] Add type button to accordion summary #39532

Merged
merged 8 commits into from
Oct 26, 2023
Merged

[joy-ui][Accordion] Add type button to accordion summary #39532

merged 8 commits into from
Oct 26, 2023

Conversation

KumarNitin19
Copy link
Contributor

Fixes: #39530

@zannager zannager added the component: accordion This is the name of the generic UI component, not the React module! label Oct 20, 2023
@zannager zannager requested a review from siriwatknp October 20, 2023 12:06
@mui-bot
Copy link

mui-bot commented Oct 20, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39532--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 2ebdf23

@danilo-leal danilo-leal changed the title fix: added intial state for accordion summary button [joy-ui][Accordion] Add an initial state for the accordion summary button Oct 20, 2023
@danilo-leal danilo-leal added the package: joy-ui Specific to @mui/joy label Oct 20, 2023
siriwatknp
siriwatknp approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the fix!

siriwatknp
siriwatknp requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR needs just type: 'button' at the AccordionSummary component.

@KumarNitin19
Copy link
Contributor Author

@siriwatknp I have resolved the comments please review.

siriwatknp
siriwatknp approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the fix!

@KumarNitin19
Copy link
Contributor Author

I think this PR needs just type: 'button' at the AccordionSummary component.

I added role because ci/circleci: test_browser-1 test case was failing.

@siriwatknp siriwatknp changed the title [joy-ui][Accordion] Add an initial state for the accordion summary button [joy-ui][Accordion] Add type button to accordion summary Oct 26, 2023
@siriwatknp siriwatknp merged commit 0123bad into mui:master Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: accordion This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[joy-ui][Accordion] The expand button acts as type="submit" by default
5 participants
@KumarNitin19 @mui-bot @siriwatknp @danilo-leal @zannager