Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][joy-ui] Adjust the templates page card design #39369

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Oct 10, 2023

This PR adds some layer of polish to the Templates card design, primarily focusing on adding labels to the buttons to clarify what both of them — the live preview & CodeSanbox — mean, following recent docs-feedback. Additionally, also changed the "open a pull request" link direction to the Contributing guide, as that seems more fitting for folks looking to open one up.

👉 https://deploy-preview-39369--material-ui.netlify.app/joy-ui/getting-started/templates/

@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels Oct 10, 2023
@danilo-leal danilo-leal self-assigned this Oct 10, 2023
@mui-bot
Copy link

mui-bot commented Oct 10, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a31b228

@danilo-leal danilo-leal requested a review from zanivan October 10, 2023 12:17
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@danilo-leal danilo-leal merged commit a95aa75 into mui:master Oct 10, 2023
@danilo-leal danilo-leal deleted the joy-ui-templates-page-tweaks branch October 10, 2023 18:26
mj12albert pushed a commit to mj12albert/material-ui that referenced this pull request Oct 10, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 13, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 13, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

3 participants