Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui][Input] Add debounce input demo #39300

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Oct 4, 2023

preview: https://deploy-preview-39300--material-ui.netlify.app/joy-ui/react-input/#debounced-input

https://www.npmjs.com/package/react-debounce-input has 224k weekly downloads, so i think debounce is pouplar enough use-case that can go be a demo.

@sai6855 sai6855 marked this pull request as draft October 4, 2023 04:24
@sai6855 sai6855 added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy component: input labels Oct 4, 2023
@mui-bot
Copy link

mui-bot commented Oct 4, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d55f6a2

@sai6855 sai6855 requested a review from siriwatknp October 4, 2023 05:28
@sai6855 sai6855 marked this pull request as ready for review October 4, 2023 05:28
@sai6855 sai6855 force-pushed the joy-debounced-input branch from 60fe218 to 9a85852 Compare October 4, 2023 08:36
@marcpachecog
Copy link

@sai6855 Hi, instead of showing an alert that disrupts the flow and also is not Joy UI design friendly, may be changed to something like the that:

Input: Input
Debounced input: Input // Will be debounced while typing in the input

@siriwatknp
Copy link
Member

Agree with @marcpachecog, the alert is a bit annoying. I think a simpler way is to have a text under the input that updates after the debounced period.

@sai6855
Copy link
Contributor Author

sai6855 commented Oct 5, 2023

@siriwatknp removed alert and added text below input

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @sai6855

@danilo-leal danilo-leal merged commit 8cfa1c8 into mui:master Oct 9, 2023
@sai6855 sai6855 deleted the joy-debounced-input branch October 9, 2023 12:23
@oliviertassinari oliviertassinari added the component: text field This is the name of the generic UI component, not the React module! label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants