[CssBaseline] use Joy GlobalStyles
#39278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
component: CssBaseline
siriwatknp
commented
Oct 3, 2023
| @@ -1,10 +1,10 @@ | |||
| 'use client'; | |||
| import * as React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import { GlobalStyles } from '@mui/system'; | |||
| import GlobalStyles from '../GlobalStyles'; | |||
There was a problem hiding this comment.
The GlobalStyles from Joy has themeId, whereas @mui/system is not.
Netlify deploy previewhttps://deploy-preview-39278--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
mnajdova
approved these changes
Oct 3, 2023
sai6855
approved these changes
Oct 4, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://github.com/mui/material-ui/pull/36829/files/af3d831e7130d34b5ab81b4b2821a387067c87a3#r1343238470.
This fix will make theme scoping work with CssBaseline.