[joy-ui][Switch] Slight adjustments to the design #39276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
zanivan
approved these changes
Oct 3, 2023
|
@siriwatknp let me know if there's anything we should be aware of given we're changing code from the actual component! |
siriwatknp
approved these changes
Oct 4, 2023
|
Looks better! |
For this case, accepting the change in argos is enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some slight adjustments to the Switch's default widths in all sizes. I've been feeling that the previous values were making it a bit too long, so finally took the time to nudge them a bit here. Additionally, I've removed the Material Design example from the Common examples section; really don't think it's worth it — like, who will use Joy UI to build Material Design? 😵 And we make the page shorter, too!
👉 https://deploy-preview-39276--material-ui.netlify.app/joy-ui/react-switch/