[SelectField] Add callback signatures to docs; improve other props. #3924

theosherry · 2016-04-10T16:08:45Z

PR has tests / docs demo, and is linted.
Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Hey, the next one for #3096.

mbrookes · 2016-04-27T19:30:45Z

src/SelectField/SelectField.js

@@ -23,25 +23,24 @@ class SelectField extends React.Component {
    /**
     * If true, the width will automatically be set according to the
     * items inside the menu.
-     * To control this width in css instead, leave this prop to `false`.
+     * To control the width in CSS instead, leave this prop to `false`.


'leave this prop set to false'?

mbrookes · 2016-04-27T19:34:40Z

Thanks @theosherry - sorry for the delay in reviewing, I've been away, and then tied up with work. Looks good apart from one possible clarification.

theosherry · 2016-05-05T15:08:22Z

@mbrookes No problem 😄

mbrookes · 2016-05-05T15:33:50Z

Thanks. 👍

oliviertassinari · 2016-05-06T20:31:44Z

@theosherry great PR regarding the docs, as always 👍.

mbrookes mentioned this pull request Apr 10, 2016

[Docs] Annotate callback props with @param tags #3096

Closed

37 tasks

mbrookes added the PR: Needs Review label Apr 27, 2016

mbrookes reviewed Apr 27, 2016
View reviewed changes

mbrookes added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI docs Improvements or additions to the documentation and removed PR: Needs Review labels Apr 27, 2016

[SelectField] Add callback signatures to docs; improve other props.

641c55c

mbrookes added PR: Review Accepted and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels May 5, 2016

oliviertassinari merged commit 6a4a8bb into mui:master May 6, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SelectField] Add callback signatures to docs; improve other props. #3924

[SelectField] Add callback signatures to docs; improve other props. #3924

theosherry commented Apr 10, 2016

mbrookes Apr 27, 2016

mbrookes commented Apr 27, 2016 •

edited

Loading

theosherry commented May 5, 2016

mbrookes commented May 5, 2016

oliviertassinari commented May 6, 2016

[SelectField] Add callback signatures to docs; improve other props. #3924

[SelectField] Add callback signatures to docs; improve other props. #3924

Conversation

theosherry commented Apr 10, 2016

mbrookes Apr 27, 2016

Choose a reason for hiding this comment

mbrookes commented Apr 27, 2016 • edited Loading

theosherry commented May 5, 2016

mbrookes commented May 5, 2016

oliviertassinari commented May 6, 2016

mbrookes commented Apr 27, 2016 •

edited

Loading