Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][joy-ui] Match Autocomplete github label demo to actual github label dropdown #39228

Merged
merged 16 commits into from
Oct 4, 2023
Merged

[docs][joy-ui] Match Autocomplete github label demo to actual github label dropdown #39228

merged 16 commits into from
Oct 4, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Sep 30, 2023 •
edited
Loading

@mui-bot
Copy link

mui-bot commented Sep 30, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39228--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0911362

@sai6855 sai6855 added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy enhancement This is not a bug, nor a new feature component: autocomplete This is the name of the generic UI component, not the React module! labels Sep 30, 2023
@sai6855 sai6855 marked this pull request as draft September 30, 2023 13:43
@sai6855 sai6855 marked this pull request as ready for review September 30, 2023 14:19
@sai6855 sai6855 force-pushed the polish-githib-label-demo branch from c8e5f7a to 0911362 Compare September 30, 2023 15:49
danilo-leal
danilo-leal approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love the attention to detail here 🤝 🙌

siriwatknp
siriwatknp approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@siriwatknp siriwatknp merged commit 4c86c2c into mui:master Oct 4, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 9, 2023
@sai6855 @mnajdova
[docs][joy-ui] Match Autocomplete github label demo to actual githu…
cdb2990 
…b label dropdown (mui#39228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sai6855 @mui-bot @siriwatknp @danilo-leal