Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][base] Add Tailwind CSS + plain CSS demo on the TextArea page #39046

Merged
merged 1 commit into from
Oct 4, 2023
Merged

[docs][base] Add Tailwind CSS + plain CSS demo on the TextArea page #39046

merged 1 commit into from
Oct 4, 2023

Conversation

alisasanib
Copy link
Contributor

I have followed (at least) the PR section of the contributing guide.

Part of #37222

@mui-bot
Copy link

mui-bot commented Sep 18, 2023 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 4ac55e3

@zannager zannager added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Sep 19, 2023
@zannager zannager requested a review from mnajdova September 19, 2023 11:36
mnajdova
mnajdova reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing a box shadow on the Tailwind demo. Maybe @zanivan can help with defining what shadow to use. Code-wise it looks good 👍

@mnajdova mnajdova requested a review from zanivan September 20, 2023 08:51
@zanivan
Copy link
Contributor

zanivan commented Sep 20, 2023

We are missing a box shadow on the Tailwind demo.

I checked, and we're also missing it on input demos and all the ones based on it. Not technically missing, but using slate palette when system is using blue and plain CSS is using cyan. Since it's not only on textArea, I think we could add it to the #38820 PR

zanivan
zanivan approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@michaldudak michaldudak merged commit 7d69acb into mui:master Oct 4, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 9, 2023
@alisasanib @mnajdova
[docs][base] Add Tailwind CSS + plain CSS demo on the TextArea page (m…
1b3dc08 
…ui#39046)

Co-authored-by: Ali Sasani Babak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova left review comments

@zanivan zanivan zanivan approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alisasanib @mui-bot @zanivan @mnajdova @michaldudak @zannager