Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base] Add Tailwind CSS + plain CSS demo on the NumberInput page #38928

Merged
merged 3 commits into from
Sep 16, 2023

Conversation

alisasanib
Copy link
Contributor

Part of #37222

@mui-bot
Copy link

mui-bot commented Sep 12, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 70b78db

@zannager zannager added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Sep 12, 2023
@zannager zannager requested a review from mnajdova September 12, 2023 10:20
@mnajdova mnajdova requested a review from mj12albert September 13, 2023 07:46
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left few comments about the class names in the plain CSS demo.

root: { className: 'CustomNumberInput' },
input: { className: 'input' },
decrementButton: {
className: 'btn decrement',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className: 'btn decrement',
className: 'CustomNumberInput-button CustomNumberInput-decrementButton',

To match the slot name and would be consistent with the other demos.

@alisasanib
Copy link
Contributor Author

@mnajdova Just applied your comment to both the introduction and basic demos. I also made some changes to the basic tailwind demo to make slotProps more scalable and consistent with other demos.

@alisasanib alisasanib requested a review from mnajdova September 13, 2023 14:27
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small polish

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants