-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][base] Add Tailwind CSS + plain CSS demo on the NumberInput page #38928
Conversation
Netlify deploy previewBundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left few comments about the class names in the plain CSS demo.
docs/data/base/components/number-input/NumberInputIntroduction/css/index.tsx
Outdated
Show resolved
Hide resolved
root: { className: 'CustomNumberInput' }, | ||
input: { className: 'input' }, | ||
decrementButton: { | ||
className: 'btn decrement', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
className: 'btn decrement', | |
className: 'CustomNumberInput-button CustomNumberInput-decrementButton', |
To match the slot name and would be consistent with the other demos.
docs/data/base/components/number-input/NumberInputIntroduction/css/index.tsx
Outdated
Show resolved
Hide resolved
@mnajdova Just applied your comment to both the introduction and basic demos. I also made some changes to the basic tailwind demo to make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small polish
docs/data/base/components/number-input/NumberInputIntroduction/tailwind/index.tsx
Outdated
Show resolved
Hide resolved
docs/data/base/components/number-input/NumberInputIntroduction/tailwind/index.js
Outdated
Show resolved
Hide resolved
docs/data/base/components/number-input/NumberInputIntroduction/tailwind/index.js
Outdated
Show resolved
Hide resolved
docs/data/base/components/number-input/NumberInputIntroduction/tailwind/index.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Marija Najdova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now :)
Part of #37222