Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve npm experience #38906

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Sep 10, 2023
@mui-bot
Copy link

mui-bot commented Sep 10, 2023

Netlify deploy preview

https://deploy-preview-38906--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 93522ad

@oliviertassinari oliviertassinari force-pushed the docs-improve-readme branch 3 times, most recently from 76983ac to 9912a7d Compare September 10, 2023 18:14
Copy link
Contributor

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a little copy-paste typo here. 👍

packages/mui-base/README.md Outdated Show resolved Hide resolved
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Olivier Tassinari <[email protected]>
@@ -1,6 +1,6 @@
<!-- markdownlint-disable-next-line -->
<p align="center">
<a href="https://mui.com/core/" rel="noopener" target="_blank"><img width="150" height="133" src="/docs/public/static/logo.svg" alt="MUI Core logo"></a>
<a href="https://mui.com/core/" rel="noopener" target="_blank"><img width="150" height="133" src="https://mui.com/static/logo.svg" alt="MUI Core logo"></a>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Base UI
<!-- markdownlint-disable-next-line -->
<p align="center">
<a href="https://mui.com/base-ui/" rel="noopener" target="_blank"><img width="150" height="133" src="https://mui.com/static/logo.svg" alt="Base UI logo"></a>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliviertassinari oliviertassinari merged commit d5d04ae into mui:master Sep 11, 2023
4 checks passed
@oliviertassinari oliviertassinari deleted the docs-improve-readme branch September 11, 2023 13:46
xcode-it pushed a commit to xcode-it/material-ui that referenced this pull request Sep 11, 2023
Signed-off-by: Olivier Tassinari <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants