[docs] Polish Slider demos #38759
Merged
[docs] Polish Slider demos #38759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
oliviertassinari
commented
Sep 2, 2023
| @@ -54,7 +54,7 @@ Similarly, the `unmountOnExit` prop removes the component from the DOM after it | |||
| The Slide component also accepts `container` prop, which is a reference to a DOM node. | |||
| If this prop is set, the Slide component will slide from the edge of that DOM node. | |||
|
|
|||
| {{"demo": "SlideFromContainer.js"}} | |||
| {{"demo": "SlideFromContainer.js", "bg": true}} | |||
There was a problem hiding this comment.
To make it easier to compare demos.
| @@ -68,17 +67,13 @@ export default function TransitionGroupExample() { | |||
| return ( | |||
| <div> | |||
| {addFruitButton} | |||
| <Box sx={{ mt: 1 }}> | |||
There was a problem hiding this comment.
No need for the Box here anymore.
| <Box sx={{ width: 200 }}> | ||
| <Box sx={{ width: 240, padding: 2 }} ref={containerRef}> |
There was a problem hiding this comment.
Move the ref to be in the online preview, makes it less confusing.
Comment on lines
-27
to
+26
| const containerRef = React.useRef(null); | ||
| const containerRef = React.useRef<HTMLElement>(null); |
There was a problem hiding this comment.
The type was wrong.
Comment on lines
0
to
7
| <Box sx={{ width: `calc(100px + 16px)`, position: 'relative', zIndex: 1 }}> | ||
| <FormControlLabel | ||
| control={<Switch checked={checked} onChange={handleChange} />} | ||
| label="Show" | ||
| /> | ||
| <Slide direction="up" in={checked} mountOnEnter unmountOnExit> | ||
| {icon} | ||
| </Slide> | ||
| </Box> No newline at end of file | ||
| <FormControlLabel | ||
| control={<Switch checked={checked} onChange={handleChange} />} | ||
| label="Show" | ||
| /> | ||
| <Slide direction="up" in={checked} mountOnEnter unmountOnExit> | ||
| {icon} | ||
| </Slide> |
There was a problem hiding this comment.
My initial objective.
| <Paper sx={{ m: 1 }} elevation={4}> | ||
| <Box component="svg" sx={{ width: 100, height: 100 }}> | ||
| <Paper sx={{ m: 1, width: 100, height: 100 }} elevation={4}> | ||
| <svg> |
There was a problem hiding this comment.
Move the style closer to where they make sense, also kill one React component along the way Box -> svg.
Netlify deploy previewBundle size report |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
xcode-it
pushed a commit
to xcode-it/material-ui
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing the change to the online preview in #38646: https://github.com/mui/material-ui/pull/38646/files#diff-abc20b07c6893afa34e4fc5d939e3ab2cae95855b4585748bee4bf3822e0cd6b
triggered me to have a quick look at improving the demos in the page.
Preview: https://deploy-preview-38759--material-ui.netlify.app/material-ui/transitions/#slide