[docs-infra] Catch duplicated trailing splashes in links #38758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-38758--material-ui.netlify.app/ Bundle size report |
This was referenced Sep 2, 2023
oliviertassinari
commented
Sep 6, 2023
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Olivier Tassinari <[email protected]>
oliviertassinari
force-pushed
the
docs-infra-detect-multi-slashes
branch
from
73260bc to
fd88c6d
Compare
github-actions
bot
removed
the
PR: out-of-date
xcode-it
pushed a commit
to xcode-it/material-ui
that referenced
this pull request
Sep 11, 2023
Signed-off-by: Olivier Tassinari <[email protected]>
|
Nice to see this CI check evolving with time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A succession of problems led to me breaking master (a71e6a0 broke the CI on master).
yarn docs:link-checkoutputted/joy-ui/integrations/material-ui/in material-ui/docs/.link-check-errors.txt, it should have been/joy-ui/integrations/material-ui//. In [docs][joy-ui] Change the customization and how-to guides docs tree #38396 it would have made it clearer that we were introducing double trailing slashes. The root problem IMHO is that when we compare URLs we should compare their final version. So in this PR, I make sure we compare the URL with trailing slashes.A side win, because these URL checks add to the runtime and bundle size, I'm now excluding them from production withprocess.env.DEPLOY_ENV !== 'production'. One step toward making the fastest UI component library documentation 🚀