-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tabs] Fix ref
type
#38717
Merged
ZeeshanTamboli
merged 4 commits into
mui:master
from
ZeeshanTamboli:issue-38391-tabs-ref-type
Aug 30, 2023
Merged
[Tabs] Fix ref
type
#38717
ZeeshanTamboli
merged 4 commits into
mui:master
from
ZeeshanTamboli:issue-38391-tabs-ref-type
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
bug 🐛
Something doesn't work
component: tabs
This is the name of the generic UI component, not the React module!
typescript
package: material-ui
Specific to @mui/material
labels
Aug 30, 2023
Netlify deploy previewhttps://deploy-preview-38717--material-ui.netlify.app/ Bundle size report |
1 task
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 30, 2023
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Aug 30, 2023
DiegoAndai
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
still see incorrect type as HTMLButtonElement |
@IlyaShorin Which version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: tabs
This is the name of the generic UI component, not the React module!
package: material-ui
Specific to @mui/material
typescript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38391
Correct the default component type, which will also resolve the issue with the ref type.
Before: https://codesandbox.io/s/crazy-euler-2c5s48?file=/Demo.tsx
After: https://codesandbox.io/s/jovial-panini-yvmwx9?file=/Demo.tsx