Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][joy-ui] Fix Link's overlay prop demo #38702

Merged
merged 3 commits into from
Sep 1, 2023
Merged

[docs][joy-ui] Fix Link's overlay prop demo #38702

merged 3 commits into from
Sep 1, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Aug 29, 2023 •
edited
Loading

As reported in #38701. Also took the opportunity to simplify it considerably!

https://deploy-preview-38702--material-ui.netlify.app/joy-ui/react-link/#overlay-prop

@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: link This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Aug 29, 2023
@danilo-leal danilo-leal requested a review from siriwatknp August 29, 2023 11:51
@danilo-leal danilo-leal self-assigned this Aug 29, 2023
@danilo-leal danilo-leal added this to the Joy UI: Stable release milestone Aug 29, 2023
@mui-bot
Copy link

mui-bot commented Aug 29, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-38702--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ad73d54

@danilo-leal danilo-leal changed the title [joy-ui][docs] Fix Link's overlay prop demo [docs][joy-ui] Fix Link's overlay prop demo Aug 30, 2023
zanivan
zanivan approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to add some tiny visual tweaks, but it indeed looks better and simpler, thanks for this!

@danilo-leal danilo-leal merged commit c0a29bc into mui:master Sep 1, 2023
@danilo-leal danilo-leal deleted the joy-link-overlay-demo branch September 1, 2023 12:21
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@danilo-leal @zanivan @mnajdova
[docs][joy-ui] Fix Link's overlay prop demo (mui#38702)
b6970f6 
Co-authored-by: zanivan <[email protected]>
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@danilo-leal @zanivan @mnajdova
[docs][joy-ui] Fix Link's overlay prop demo (mui#38702)
4be838b 
Co-authored-by: zanivan <[email protected]>
xcode-it pushed a commit to xcode-it/material-ui that referenced this pull request Sep 11, 2023
@danilo-leal @zanivan @xcode-it
[docs][joy-ui] Fix Link's overlay prop demo (mui#38702)
5a1e1e6 
Co-authored-by: zanivan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanivan zanivan zanivan approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees

@danilo-leal danilo-leal

Labels
component: link This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
Joy UI
Status: Recently completed
Milestone
Joy UI: Stable release
Development

Successfully merging this pull request may close these issues.
3 participants
@danilo-leal @mui-bot @zanivan