-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Mark unstable components with a chip in the nav drawer #38573
Conversation
Netlify deploy previewhttps://deploy-preview-38573--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On X we were using 🧪 in the name, but a chip seems more stable.
I let @danilo-leal make sure the design is 👍
@mui/x We will be able to replace the page title including a 🧪 by the property unstable: true
On X we have a "NEW" badge that is also often used on unstable elements. |
Having both a 'new' and 'unstable' chips is a bit confusing. We should probably have a clear definition of what is new and what is unstable 🤔 What do we mark as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design-wise, it looks good! But echoing folks here on whether we want to have both New
and Unstable
or one or the other? From a distance, they don't sound like the same thing ⎯ I'd assume that New
is something fresh that's ready for me to use, whereas Unstable
sounds like a beta thing?
I see it exactly like that: "New" is ready to use, stable, and shiny, whereas "unstable" is, well, unstable :) Nothing in "new" suggests the component's API can still change between majors. We could add tooltips to provide further explanation to all the chips. |
We've discussed the issue with the Core team. The word "unstable" has perhaps some negative connotations. Other options that we feel would work better include "alpha" or "experimental". Do you have any preferences in this matter? |
I like experimental, because "alpha" can be weird when it's in a component that is not itself in alpha |
The only drawback I could see for "experimental" is that it's a longer word, so it takes up a lot of space on the menu! 😅 But as long as it works design-wise then I think it's preferable over "unstable." |
We could also use a "preview" label instead of unstable, this is what Radix UI uses, it shorter and to the point :) |
By the way, how does the lab package will evolve in the future? |
We're leaning toward it. Having a separate lab package for each stable one would require much bigger effort. |
I changed the text to "Preview". @danilo-leal let me know what you think about the color. I wouldn't leave it as grey, as it's too similar to "Planned" |
@michaldudak cool, that's looking good! @mnajdova killed it with this word suggestion 😬 It doesn't seem we're using a blue chip yet. I think I'd use that and save the green one for "New", it seems more fitting. So, the final arrangement would be:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🚢 it!
(Forgot to mark the review above as approve 🤦)
Realizing we don't have any way of showing unstable components, I added a chip (similarly to "planned") to the app nav drawer entries.
I marked Base UI's Number Input as such: