Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Box] Remove component from TypeMap #38168

Merged
merged 2 commits into from
Jul 31, 2023
Merged

[Box] Remove component from TypeMap #38168

merged 2 commits into from
Jul 31, 2023

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Jul 26, 2023 •
edited
Loading

Props in Box's TypeMap had the component prop defined, unlike all other components in Material UI. This has proven to cause issues (see #35924).
The definition of the component field was moved to BoxProps in #38084.

Fixes #34068

@michaldudak michaldudak added bug 🐛 Something doesn't work typescript component: Box The React component. labels Jul 26, 2023
@michaldudak michaldudak requested a review from mnajdova July 26, 2023 13:22
@mui-bot
Copy link

mui-bot commented Jul 26, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-38168--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 878f68a

mnajdova
mnajdova approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@michaldudak michaldudak merged commit de38693 into mui:master Jul 31, 2023
@michaldudak michaldudak deleted the box-typemap branch July 31, 2023 07:34
richbustos pushed a commit that referenced this pull request Aug 4, 2023
@michaldudak
[Box] Remove component from TypeMap (#38168)
8d73246
michaldudak added a commit to michaldudak/material-ui that referenced this pull request Aug 7, 2023
@michaldudak
Revert "[Box] Remove component from TypeMap (mui#38168)"
66a8c09 
This reverts commit de38693.
@michaldudak michaldudak mentioned this pull request Aug 7, 2023
Merged
mnajdova pushed a commit that referenced this pull request Aug 7, 2023
@michaldudak
Revert "[Box] Remove component from TypeMap (#38168)" (#38356)
745bd53
richbustos pushed a commit that referenced this pull request Aug 7, 2023
@michaldudak
[Box] Remove component from TypeMap (#38168)
f5f12b4
richbustos pushed a commit that referenced this pull request Aug 7, 2023
@michaldudak
Revert "[Box] Remove component from TypeMap (#38168)" (#38356)
c2481e8
@Methuselah96 Methuselah96 mentioned this pull request Aug 9, 2024
Closed
2 tasks
@DiegoAndai DiegoAndai mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Box The React component. typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Box] Type error when too many properties exist in JSX.IntrinsicElements
3 participants
@michaldudak @mui-bot @mnajdova