Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy] Replace leftover Joy- prefix with Mui- #38086

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jul 21, 2023

closes #38067

This will break the application that is using hardcoded Joy- className.

To migrate, replace Joy- with Mui-:

- Joy-
+ Mui-

Those who are importing classes from components are safe from this breaking change.


@siriwatknp siriwatknp added bug 🐛 Something doesn't work breaking change package: joy-ui Specific to @mui/joy labels Jul 21, 2023
@siriwatknp siriwatknp requested a review from a team July 21, 2023 09:03
@mui-bot
Copy link

mui-bot commented Jul 21, 2023

Netlify deploy preview

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 9524231

Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that it needs updating in the Anatomy section of the Radio Button docs. Everything else looks fine.

@siriwatknp
Copy link
Member Author

I just noticed that it needs updating in the Anatomy section of the Radio Button docs. Everything else looks fine.

Thanks @ZeeshanTamboli

@siriwatknp siriwatknp merged commit eb04c09 into mui:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change bug 🐛 Something doesn't work package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Joy] Naming Convention
4 participants