Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] Remove deprecated BackdropComponent and BackdropProps from tests #38018

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Jul 18, 2023

BackdropComponent and BackdropProps are deprecated but those are still used in few tests, This PR removes those instances.

current documentation for these props : https://mui.com/material-ui/api/modal/#props

@sai6855 sai6855 added component: modal This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material enhancement This is not a bug, nor a new feature and removed enhancement This is not a bug, nor a new feature labels Jul 18, 2023
@mui-bot
Copy link

mui-bot commented Jul 18, 2023

Netlify deploy preview

https://deploy-preview-38018--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3ee8a59

@sai6855 sai6855 added the test label Jul 18, 2023
@sai6855 sai6855 changed the title [Modal] Remove deprecated BackdropComponent from tests [Modal] Remove deprecated BackdropComponent and BackdropProps from tests Jul 18, 2023
@zannager zannager requested a review from michaldudak July 18, 2023 10:11
@sai6855 sai6855 requested review from DiegoAndai and removed request for michaldudak July 18, 2023 10:15
@sai6855 sai6855 requested a review from ZeeshanTamboli July 18, 2023 10:24
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@sai6855
Copy link
Contributor Author

sai6855 commented Jul 18, 2023

@DiegoAndai feel free to merge if you are happy with changes. I don't have access to merge

@DiegoAndai DiegoAndai merged commit db2968e into mui:master Jul 18, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 18, 2023

Sweet, I'm linking this to #33416 to help keep track of the progress. It would be great to continue this effort. I imagine this is part of getting to v6.

@sai6855 sai6855 deleted the remove-prop branch July 18, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: modal This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants