Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy][Select] Fix type error caused by custom variant #37996

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

OmPr366
Copy link
Contributor

@OmPr366 OmPr366 commented Jul 16, 2023

Fixes #37968

@mui-bot
Copy link

mui-bot commented Jul 16, 2023

Netlify deploy preview

https://deploy-preview-37996--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against ec31d7b

@sai6855 sai6855 added component: select This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Jul 16, 2023
@mj12albert
Copy link
Member

@OmPr366 Thanks for your contribution 👍

I checked and the fix works: https://codesandbox.io/s/https-github.aaakk.us.kg-mui-material-ui-pull-37996-vkvldp?file=/src/App.tsx

PS – the next time you submit an issue you could attach a minimal demo in CodeSandbox (fork this template) to help us test and review faster ~

@mj12albert mj12albert changed the title [fix][Joy][Select] Custom variant type error fix [Joy][Select] Fix type error caused by custom variant Jul 17, 2023
@mj12albert mj12albert merged commit 19a801c into mui:master Jul 17, 2023
@OmPr366 OmPr366 deleted the Select-Box branch July 24, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Joy][Select] Custom variant is causing type error
4 participants