[docs-infra] Square drawer corners #37970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
design
Netlify deploy previewhttps://deploy-preview-37970--material-ui.netlify.app/ Bundle size report |
danilo-leal
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
I'm definitely not against it but I think this is mostly a stylistic decision ⎯ the reasoning about the number of users between Calendar vs. Gmail doesn't seem like decisive data for this detail. I particularly enjoy the rounded corners more (would round them even more than what it is today). But all good to move forward regardless 🤙
|
With vertical drawers (horizontal in this PR), a rounded corner feels OK on my end, I think it's because when vertical it covers the whole screen width. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding https://m3.material.io/components/navigation-drawer/overview: Google Calendar has a round corner while Gmail has a square corner on my Android phone. Gmail feels much better. Gmail has x2 more users than Google Calendar according to https://play.google.com/store/apps/details?id=com.google.android.gm&hl=en&gl=US. So I feel like we could do the same for the docs.
Before
After
I noticed this in #37933.