[docs-infra] Improve performance hideToolbar: true #37969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
core
Comment on lines
375
to
379
| if (demoOptions.hideToolbar === false) { | ||
| throw new Error( | ||
| [ | ||
| '"hiddenToolbar": false is already the default.', | ||
| '"hideToolbar": false is already the default.', | ||
| `Please remove the property in {{"demo": "${demoOptions.demo}", …}}.`, |
Comment on lines
-179
to
+184
| {canonicalAs.startsWith('/joy-ui/') ? ( | ||
| {productId === 'joy-ui' ? ( |
There was a problem hiding this comment.
More resilient logic
Comment on lines
-544
to
+564
| <NoSsr defer fallback={<DemoToolbarFallback />}> | ||
| <NoSsr fallback={<DemoToolbarFallback />}> |
There was a problem hiding this comment.
Extra render useless
| }); | ||
| setDemoKey(); | ||
| }; | ||
| const resetDemo = React.useMemo( |
There was a problem hiding this comment.
Memoize to avoid rerendering the DemoSandbox on hover.
| {/* TODO: BrandingProvider shouldn't be needed, it should already be at the top of the docs page */} | ||
| <BrandingProvider {...(demoData.productId === 'joy-ui' ? { mode } : {})}> | ||
| {demoOptions.hideToolbar ? null : ( | ||
| {demoOptions.hideToolbar ? null : ( |
There was a problem hiding this comment.
We can opt-out of a lot more things when demoOptions.hideToolbar is false.
Netlify deploy previewhttps://deploy-preview-37969--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
fix-memo-regression
branch
from
ecae19e to
65294ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick clean-up on the logic.
This effort is connected to the need to improve the performance of the docs pages. They should render much faster. We are reinforcing the idea that CSS-in-JS or event our components are slow hence you shouldn't use them.