Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove nx dependency #37964

Merged
merged 3 commits into from
Jul 18, 2023
Merged

[core] Remove nx dependency #37964

merged 3 commits into from
Jul 18, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jul 14, 2023

See #37884 (comment)

This dependency is unnecessary

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Jul 14, 2023
@Janpot Janpot changed the title Remove nx dependency [core] Remove nx dependency Jul 14, 2023
@mui-bot
Copy link

mui-bot commented Jul 14, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-37964--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 2be4c0c

@Janpot Janpot marked this pull request as ready for review July 14, 2023 13:37
@Janpot Janpot requested a review from michaldudak July 14, 2023 13:37
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 17, 2023
michaldudak
michaldudak approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It seems to be working well.

@Janpot Janpot enabled auto-merge (squash) July 18, 2023 10:11
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 18, 2023
@Janpot Janpot merged commit 8ef6ff4 into mui:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @mui-bot @michaldudak