Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Improve disableToc={true} support #37931

Merged
merged 2 commits into from
Jul 12, 2023
Merged

[docs-infra] Improve disableToc={true} support #37931

merged 2 commits into from
Jul 12, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 11, 2023 •
edited
Loading

Something I noticed from https://twitter.com/MUI_hq/status/1678486986137432074

  1. Fix the layout so it's stable when moving from a page that has disableToc to a page that doesn't.
  2. Enable disableToc={true} on https://mui.com/base-ui/all-components/ to give it more space (half of the tocs width), same effect on the others page that uses it, like the Material Icon search page, or the template pages.

https://deploy-preview-37931--material-ui.netlify.app/base-ui/all-components/

@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Jul 11, 2023
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Jul 11, 2023
@mui-bot
Copy link

mui-bot commented Jul 12, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-37931--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 077410b

danilo-leal
danilo-leal approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one! Definitely improves the navigation experience 🤙

@danilo-leal danilo-leal merged commit 3ad3187 into mui:master Jul 12, 2023
@oliviertassinari oliviertassinari deleted the docs-disable-toc branch July 12, 2023 10:09
@oliviertassinari
Copy link
Member Author

arf yarn docs:api removed the disableToc, fixed in #37941.

@oliviertassinari oliviertassinari mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: base-ui Specific to @mui/base scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-bot @danilo-leal