-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Skeleton] Add Joy UI Skeleton
component
#37893
Conversation
Netlify deploy preview@mui/joy: parsed: +1.43% , gzip: +1.42% Bundle size reportDetails of bundle changes (Toolpad) |
Great work, @siriwatknp ! |
The only reason is that I follow the Skeleton from Material UI but we can use a different default animation for Joy UI. I will update the default animation to |
Yep, now I see it! I think we can roll back to |
@zanivan I think it is ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking awesome to me! 🎉 Pushed a couple of docs-related changes but would love a review from @samuelsycamore for a much better copywriting perspective 🤙
<Skeleton variant="overlay"> | ||
<img | ||
alt="" | ||
src="https://images.unsplash.com/photo-1686548812883-9d3777f4c137" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is huge: 4 MB, fixed in 08adce6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
<img | ||
alt="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this demo. As far as I understand the use case for the skeleton, it's to wait for the API to return the data, so we don't know the image URL at this point, so why is not a Skeleton with no child?
<img | |
alt="" |
If it's because the image already has its layout, then
<img | |
alt="" | |
<img | |
alt="" | |
src="data:image/gif;base64,R0lGODlhAQABAAD/ACwAAAAAAQABAAACADs=" |
would probably make more sense.
It might be more than this. Facebook used to do it right with "wave", they moved to "pulse". https://www.tiktok.com/ uses wave and it doesn't feel great. I almost wonder if we shouldn't remove "wave". https://www.quora.com/answer does the "wave" well though. You can see it by blocking One bug: Screen.Recording.2023-07-22.at.02.04.03.movhttps://master--material-ui.netlify.app/joy-ui/react-skeleton/ |
@siriwatknp just wanted to say that although I never got a chance to review the docs for this PR, I don't think I needed to honestly. Your writing has gotten really good over the last year, and I can tell that you've internalized the company style guide at this point because I don't really have any copyediting suggestions. Great work! |
That's because of your writing style guide 😚. |
Uhuhuhuh Thanks a lot for this! I was caught by surprise when importing my custom skeleton and it pulled tje joy one instea! <3 <3 <3 |
closes #36105
Preview: https://deploy-preview-37893--material-ui.netlify.app/joy-ui/react-skeleton/
Features: https://twitter.com/siriwatknp/status/1678294410872893440