Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @types/node to ^20.4.2 #37880

Closed
wants to merge 1 commit into from
Closed

Bump @types/node to ^20.4.2 #37880

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 9, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/node (source) ^18.16.19 -> ^20.4.2 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Update of dependencies label Jul 9, 2023
@mui-bot
Copy link

mui-bot commented Jul 9, 2023

Netlify deploy preview

https://deploy-preview-37880--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against de7e57a

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No ts errors, so I think this is safe to be merged. cc @mui/code-infra

@Janpot
Copy link
Member

Janpot commented Jul 10, 2023

Ideally @types/node major/minor versions are aligned with the Node.js version we are running on. See https://github.com/definitelytyped/definitelytyped#how-do-definitely-typed-package-versions-relate-to-versions-of-the-corresponding-library
It doesn't matter that much as the APIs are usually backwards compatible, but the @tyeps/node may contain features that are not available yet on the Node.js version we use.

I'm not sure however whether there's an easy way to sync Node.js with @types/node in renovate bot.

@Janpot
Copy link
Member

Janpot commented Jul 10, 2023

Actually, looks like they have a preset for this

"extends": ["helpers:disableTypesNodeMajor"]

@ZeeshanTamboli
Copy link
Member

Last week, I closed this update and Renovate indicated it would ignore the update (#37793 (comment)). However, it seems that is not true. MUI X has locked the version to 18 in mui/mui-x#9107, and I was planning to do the same. Please refer to the discussion in #37793.

@renovate renovate bot changed the title Bump @types/node to ^20.4.1 Bump @types/node to ^20.4.2 Jul 13, 2023
@renovate renovate bot force-pushed the renovate/node-20.x branch from 18f2ea9 to de7e57a Compare July 13, 2023 02:17
@renovate renovate bot deleted the renovate/node-20.x branch July 14, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants