[FormControlLabel] Fix misplaced asterisk when labelPlacement is provided
#37831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-37831--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
1 task
|
Argos is being weird this week for some reason! It's not just you. 😅 |
…ce-labelPlacement
|
Argos is right in this case - if you open your before/after examples you'll notice that the "after" one has the asterisks positioned slightly higher. |
|
@michaldudak I fixed it now. I had checked the documentations (which Argos checks against), and there I couldn't visually identify any differences. However, thanks for pointing it out in the CodeSandbox examples. |
michaldudak
approved these changes
Jul 12, 2023
ZeeshanTamboli
deleted the
issue-37281-required-asterisk-in-wrong-place-labelPlacement
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37281
I was not able to push on PR #37286, so created this one and closed that.
Argos detected changes (https://app.argos-ci.com/mui/material-ui/builds/14969/51477913), but I couldn't find any differences after inspecting between the production version and this PR.
Before: https://codesandbox.io/s/exciting-feather-0d0e2o?file=/demo.tsx
After: https://codesandbox.io/s/friendly-nightingale-pt92rn