[docs-infra] Fix TypeScrit error in demo export #37830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
oliviertassinari
force-pushed
the
codesandbox-fix-typescript
branch
from
7704228 to
97b46b9
Compare
Netlify deploy previewhttps://deploy-preview-37830--material-ui.netlify.app/ Bundle size report |
oliviertassinari
commented
Jul 5, 2023
Comment on lines
+51
to
+52
| // document.querySelector returns 'Element | null' but createRoot expects 'Element | DocumentFragment'. | ||
| const type = demoData.codeVariant === 'TS' ? '!' : ''; |
There was a problem hiding this comment.
The actual fix, explained in https://www.typescriptlang.org/docs/handbook/2/everyday-types.html#non-null-assertion-operator-postfix-, the rest is code cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you export any of the demos with TypeScript to CodeSandbox, StackBlitz, you will get:
which breaks
yarn build.I have found thing working on https://www.notion.so/mui-org/Monthly-meeting-2023-07-04-de26e366aa4148c6ae9cb7bdd55165c0?pvs=4#ac80a962246842dfa60a96cf98078a75, frustrating, I wanted to build the app in production mode.
Preview: https://deploy-preview-37830--material-ui.netlify.app/material-ui/react-alert/#basic-alerts