-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][base] Add Tailwind CSS & plain CSS demo on the Switch page #37728
[docs][base] Add Tailwind CSS & plain CSS demo on the Switch page #37728
Conversation
I am not sure about the focus visible styles, they look too much like Material UI. Maybe we should use the shadow for the other components: |
Netlify deploy previewBundle size report |
We could do like Joy UI—and some other libs too—and make the focus visible on the track instead of the thumb. However, I don't think it's much of a problem to look like Material UI, though. IMO, I like the focus on the thumb, what do you think? |
I agree that the focus on the thumbs is not inherently a bad thing ⎯ it's slightly more intuitive that outlining the entire switch component. Would customize/polish it a bit though so it doesn't look as rough 😬 |
@danilo-leal should I wait for this, or can we do it as a follow up? |
…//github.com/mnajdova/material-ui into docs/base-switch-tailwind-css-plain-css-demo
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the Tailwind and plain CSS demo is working, I think we could merge this. Other visual tweaks on the demos could be done on #37740
Signed-off-by: Marija Najdova <[email protected]>
Part of #37222
TODO:
CreateReactApp
with the new extended theme after [docs][base] Add Tailwind CSS & plain CSS demos on the Input page #37685 is merged