-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][base] Add Tailwind CSS + plain CSS demo on the Select page #37725
[docs][base] Add Tailwind CSS + plain CSS demo on the Select page #37725
Conversation
Netlify deploy previewBundle size report |
docs/data/base/components/select/UnstyledSelectBasic/css/index.js
Outdated
Show resolved
Hide resolved
docs/data/base/components/select/UnstyledSelectBasic/css/index.js
Outdated
Show resolved
Hide resolved
docs/data/base/components/select/UnstyledSelectBasic/css/index.tsx
Outdated
Show resolved
Hide resolved
I made a slight tweak to the Tailwind demo background by using slate-800 instead of 900—This will give it a lighter tone, aligning it more closely with the plain CSS and System demos. Also, for some reason the Tailwind demo has a very strong border on the |
Is it intended for the Tailwind demo to have a different font on the combobox? |
We decided to not use the same font as the other demos (system and plain CSS) on the first pull request. Happy to revisit the subject. cc @danilo-leal |
I fixed it, looks better now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the adjustments @mnajdova it looks good!
I've added a few more tweaks on dark mode just to increase the contrast and be a bit more visually consistent overall, but I think we're good to go!
const isDarkMode = useIsDarkMode(); | ||
|
||
return ( | ||
<style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaldudak How do you write <style> tag as a React Component?
I've tried this but occurring error that doesn't allow <style> tag as JSX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to write style
's contents as a string:
<style>
{`div {
color: red;
}`}
</style>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Preview: https://deploy-preview-37725--material-ui.netlify.app/base-ui/react-select/#basics
Part of #37222