-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ToggleButton][Joy] Add ToggleButton
component
#37716
Conversation
Netlify deploy preview@mui/joy: parsed: +0.76% , gzip: +0.75% Bundle size reportDetails of bundle changes (Toolpad) |
Preview: https://deploy-preview-37716--material-ui.netlify.app/experiments/joy/toggle-button/ With box-shadow: Screen.Recording.2566-06-25.at.12.06.14.movWithout box-shadow: Screen.Recording.2566-06-25.at.12.06.44.mov@zanivan Which version do you prefer 👆? |
@siriwatknp I'm just adding it here to keep it documented:
|
@zanivan it looks better with Screen.Recording.2566-06-27.at.09.33.54.mov |
@zanivan Ready for the first review! https://deploy-preview-37716--material-ui.netlify.app/joy-ui/react-toggle-button/ |
@siriwatknp It looks good! I've just added some tweaks to the texts. While I was reviewing, two things came to my mind:
|
That makes a lot of sense. Let me update the page. |
@zanivan I think it is ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe wait for a review from @danilo-leal or @samuelsycamore to polish out the copy a bit if needed, but it looks good to me! ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Gave it a shot at the docs formatting/editing but @samuelsycamore should definitely take a look everything's sounding good!
closes #36617
New