-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[notifications] Add notification for first Charts release #37679
[notifications] Add notification for first Charts release #37679
Conversation
Netlify deploy previewhttps://deploy-preview-37679--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though for latter, the banner could be replaced with the article about new features
Much agree, removed. I would be in favor of removing this slot altogether. It feels a bit like a strange tradeoff. If it's not really important, it can go in the notification panel, it's much better for devs to be able to free their space once seen. If it's more important, then it might be too easy to miss, it could be better as a top panel, like Vue has:

https://vuejs.org/guide/essentials/application.html
HashiCorp has:

https://developer.hashicorp.com/packer
cc @danilo-leal
Co-authored-by: Alexandre Fauquette <[email protected]> Signed-off-by: Olivier Tassinari <[email protected]>
re Banner: I like the idea of the top banner and I think we even have it developed already (we've used it for the v5 release if I recall correctly). Not to derail the PR too much but there's a trade-off I see for these components used to promote stuff: the top full-width banner will definitely be seen but exactly because it is aggressive to the navigation, should be removed faster, whereas the little callout that we have on the navbar can be less distracting but persist longer (this v6 one has been there for a while). If we're keeping what we have right now, I think we should at least update it to mention the Charts instead! Maybe with a different emoji & color? |
The issue for me, on why it doesn't work (why I proposed to remove it) is that with the goal to display it longer, people will get accustomed to it, developing banner blindness for it. On the other hand, with the notification badge, it will only show if there is something new. |
Regarding the change itself, I'm not sure we would want to announce it in this format. There is cognitive dissonance for me to use the notification setting for something that isn't a blog post. Either 1. it's important, so it should be a blog post, or 2. it's not important, and so it shouldn't be a notification. We don't fit in 1 or 2, our case feels off. By "blog post", I mean either https://mui.com/blog/ or an extended-release note like https://github.com/prisma/prisma/releases/tag/4.16.0, something that gives the audience a reason to be excited: explaining the problem, why this is needed, the solution is secondary. So I think either:
@richbustos what was the release strategy of the charts? |
Signed-off-by: José Rodolfo Freitas <[email protected]>
After discussing with @oliviertassinari, we agreed it's fine to release the notification to reach out to the core community. |
It sounds fair 👍 |
This comment was marked as off-topic.
This comment was marked as off-topic.
@joserodolfofreitas would love to take over. I’m thinking video announcement and blog collab. Will slack you |
😁
|
Summary
Notification inviting users to check out charts