[Button][material-next] Fix some event handlers being ignored

[DiegoAndai]

• I have followed (at least) the PR section of the contributing guide.

Fixes: #37645

Four event handlers were not being handled in getRippleHandlers, so those were lost:

• onClick
• onFocus
• onKeyUp
• onKeyDown

I also added tests for those events.

[DiegoAndai]

Let me know if you think we should add other events to the test.

[mui-bot]

Netlify deploy preview

https://deploy-preview-37647--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against bbe3641

[DiegoAndai]

Hey @mnajdova! Thanks for the feedback. I refactored the fix to use useSlotProps

The test_static test is failing because yarn proptypes wants to remove the four event handlers (onClick, onFocus, onKeyUp, onKeyDown) from the Button component's proptypes 🤔 I think that's incorrect, they shouldn't be removed, but I'm not sure, what do you think? Should the inherited props from button be included in the Button component proptypes?

[mnajdova]

The test_static test is failing because yarn proptypes wants to remove the four event handlers (onClick, onFocus, onKeyUp, onKeyDown) from the Button component's proptypes 🤔 I think that's incorrect, they shouldn't be removed, but I'm not sure, what do you think? Should the inherited props from button be included in the Button component proptypes?

Well this is somewhat expected as we are not handling them in the component, but they are handled in the hook. @michaldudak what are we doing with these use-cases in Base UI?

[michaldudak]

These event handlers are common to all HTML elements, so they are not explicitly listed in Button or useButton. Also, they are not directly used by the hook (or the component), so essentially, they are not needed (although it does feel weird that onClick isn't defined on a button).

[mnajdova]

although it does feel weird that onClick isn't defined on a button

We can discuss this separately