-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IconButton] add callback signatures to docs #3709
Conversation
*/ | ||
onBlur: React.PropTypes.func, | ||
|
||
/** | ||
* Callback function for when the component gains focus. | ||
* Callback function fired when the element gains focus. | ||
* @param {object} event `focus` event targeting the lement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
element
Oops sry. Fixed the typo. |
Thanks for continuing through these, it's really appreciated! Would you be happy to standardise the wording on the other prop descriptions while you're there? If you do you can squash onto this commit. |
@mbrookes No problem. I'll give it a go when I get home tonight. |
Thanks! 👍 |
Ok, let me know what you think. I tried to be consistent with what I've done so far. |
Thanks @theosherry - I should have mentioned it (but I assumed you were already working from it as your callback changes were in line): https://github.com/callemall/material-ui/wiki/Documentation#description-wording Could you follow the 'If true, ... ' pattern for the Doesn't have to be word for word, as there are inconsistencies everywhere due to how Material-UI has evolved, but the more cleanups the better! |
Of course. Sorry, I forgot about those guidelines. |
Thanks, looks good! 👍 |
Thanks a lot @theosherry 👍 |
[IconButton] add callback signatures to docs
Hey, PR for #3096 .