Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codemod][base] Improve the removal of component prop codemod script #36952

Merged
merged 2 commits into from
Apr 25, 2023
Merged

[codemod][base] Improve the removal of component prop codemod script #36952

merged 2 commits into from
Apr 25, 2023

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Apr 21, 2023 •
edited
Loading

Problem:

  • Spread attribute was ignored

Expected Result:

-<Input component={CustomRoot} {...others} />;
+<Input slots={{ root: CustomRoot }} {...others} />;

@hbjORbj hbjORbj requested a review from mnajdova April 21, 2023 15:12
@hbjORbj hbjORbj added package: codemod Specific to @mui/codemod package: base-ui Specific to @mui/base labels Apr 21, 2023
@hbjORbj hbjORbj self-assigned this Apr 21, 2023
@mui-bot
Copy link

mui-bot commented Apr 21, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-36952--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 905ea67

@hbjORbj hbjORbj mentioned this pull request Apr 22, 2023
Closed
1 task
@hbjORbj hbjORbj changed the title [codemod][base] Support spread attribute in removal of component prop script [codemod][base] Improve the removal of component prop codemod script Apr 23, 2023
mnajdova
mnajdova approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@hbjORbj hbjORbj merged commit c9568ea into mui:master Apr 25, 2023
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@hbjORbj @binh1298
[codemod][base] Improve the removal of component prop codemod script (
976c5f0 
mui#36952)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees

@hbjORbj hbjORbj

Labels
package: base-ui Specific to @mui/base package: codemod Specific to @mui/codemod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @mui-bot @mnajdova