Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Add the Joy UI marketing page #36829

Closed
wants to merge 161 commits into from

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Apr 10, 2023

To-do refinements

Pre-review batch of to-dos
  • Use the branding theme colors instead of Joy UI ones on the page (dark mode gets a bit janky).
  • Components section playground adjustment.
  • Features section "Color inversion" code fix.
  • Features section "Global variants" component demo simplification.
  • Add space + component for more testimonials.
  • Update the Components section icons.
  • Remove feather icons from the Rental dashboard demo (wait for [docs][joy-ui] Refine the Rental dashboard template #39059)

@siriwatknp siriwatknp added the website Pages that are not documentation-related, marketing-focused. label Apr 10, 2023
@mui-bot
Copy link

mui-bot commented Apr 10, 2023

Netlify deploy preview

https://deploy-preview-36829--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 14c6199

@danilo-leal danilo-leal added this to the Joy UI: Stable release milestone May 31, 2023
@danilo-leal danilo-leal added the package: joy-ui Specific to @mui/joy label May 31, 2023
@danilo-leal danilo-leal changed the title [DO NOT MERGE] Create Joy UI marketing page [DO NOT MERGE][website] Create Joy UI marketing page May 31, 2023
@danilo-leal danilo-leal changed the title [DO NOT MERGE][website] Create Joy UI marketing page [DO NOT MERGE][website] Add Joy UI marketing page May 31, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 18, 2023
@danilo-leal danilo-leal changed the title [DO NOT MERGE][website] Add Joy UI marketing page [website] Add the Joy UI marketing page Aug 1, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 1, 2023
@siriwatknp
Copy link
Member Author

@danilo-leal pushed these changes:

  • Automatic adjustment demo
  • Fix the solid and solid demo for the Global variant section
  • Fix layout shift after template is loaded

Comment on lines +62 to +64
Joy UI is for those that appreciate the comprehensiveness and reliability of Material
UI, but don't want Material Design. It's design agnostic and built to be
tailored to your specific design language.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should avoid all mention of Material UI and Material Design here in the hero section. That can come later. We should use the opportunity to describe what it is more than what it's not. What are the top two or three key value propositions worth highlighting here? "Joy UI is great because..."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, yeah! Meta note: Every piece of copy we're using on the page at the moment is either what we iterated on while the page was still in the Figma stage or place-holder stuff I came up with — so, taking advantage of this comment to extend the invite to revise the entire page's copywriting! 🤙 Some comments about specific parts were already dropped, and I'd like to get your take on them (click on the "Load more" up there a few times to see the previous thread 😬).

For this comment specifically, though, I'd likely highlight these aspects: 1) UI design (minimal, sleek, lightly opinionated); 2) customization UX (CSS variables, automatic features, etc.); 3) either DX (which can be covered in the previous topic) or breadth of components. Not fully sure about the third...

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 17, 2023
@mbrookes
Copy link
Member

For the "Rental" example, the map appears to a scan of a paper map. It's slightly skewed, and even has a crease in it. Should we perhaps use a screenshot instead? Something like:

image

(same location as the list)

Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More random feedback, mostly on the copy, which I appreciate was always a WIP.

<GradientText>beautiful components and DX</GradientText>
</Typography>
}
description="Joy UI components were extracted from Material UI, featuring the same robust engineering, and quickly trusted by many community members."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if developers might be concerned that Joy UI has inherited Material Design specific code baggage? Perhaps we could refer to it more obliquely?:

Suggested change
description="Joy UI components were extracted from Material UI, featuring the same robust engineering, and quickly trusted by many community members."
description="Joy UI components are built on the same robust engineering foundations as Material UI that are trusted by our growing community."

(or some such)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, reading it again, this doesn't really follow from the H2 content of "beautiful components and DX"...

icon: <AccessibilityNewRounded fontSize="small" color="primary" />,
title: 'Accessibility',
description:
'Joy UI is built off of from Base UI, which delivers several built-in accessibility features.',
Copy link
Member

@mbrookes mbrookes Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcting the grammar:

Suggested change
'Joy UI is built off of from Base UI, which delivers several built-in accessibility features.',
'Joy UI is built with Base UI, which delivers several built-in accessibility features.',

However "several built-in accessibility features" doesn't sound like we have given much attention to accessibility. Would it be fair to word this more strongly, or is that actually the case?

icon: <HandymanRoundedIcon fontSize="small" color="primary" />,
title: 'Highly customizable',
description:
'Complete control over how the component looks, powered by several customization tools.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Complete control over how the component looks, powered by several customization tools.',
'Complete control over how the component looks, powered by several customization features.',

icon: <InvertColorsRoundedIcon fontSize="small" color="primary" />,
title: 'Beautiful out of the box',
description:
'Start looking good with very little effort. Joy UI is designed to be simple and agnostic.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of editing @danilo-leal's sugestion.

title: 'Beautiful out of the box',
description:
'Start looking good with very little effort. Joy UI is designed to be simple and agnostic.',
link: '/joy-ui/getting-started/#beautiful-out-of-the-box/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hash fragment links don't seem to be working for some reason.

Enhance your <GradientText>design workflow</GradientText>
</Typography>
}
description="The Design kits contain many of the Material UI components with states, variations, colors, typography, and icons. We frequently update it to sync with the most up-to-date release."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description="The Design kits contain many of the Material UI components with states, variations, colors, typography, and icons. We frequently update it to sync with the most up-to-date release."
description="The Design kits contain many of the Material UI components with states, variations, colors, typography, and icons. We frequently update it to keep in sync with the latest release of Joy UI."

import Frame from 'docs/src/components/action/Frame';
import Link from 'docs/src/modules/components/Link';

const DEMOS = ['Color & Typography', 'Components', 'Variants'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I misunderstanding, or are the demos for these reversed? 'Color & Typography' seems to show screenshots for Components, and vice versa.

}
/>
<GetStartedButtons
primaryUrl={ROUTES.joyDocs}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this section is about Community should we be linking to perhaps Discord and Github instead?

title={
<Typography variant="h2" sx={{ mt: 1, maxWidth: 600, mx: 'auto' }}>
Kick-start your new product with <br />
<GradientText>beautiful components and DX</GradientText>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<GradientText>beautiful components and DX</GradientText>
<GradientText>beautiful components and great DX</GradientText>

@mbrookes
Copy link
Member

Oops! This popped up on my "participating" notifications for some reason, so I thought it must still be being worked on, but I see there hasn't been any activity for a while, so I'm guess it's on-hold (for obvious reasons). Please disregard for now.

@danilo-leal
Copy link
Contributor

I'll leave this PR closed as we're pausing it for now! We can always re-open it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: joy-ui Specific to @mui/joy PR: out-of-date The pull request has merge conflicts and can't be merged website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[joy-ui] Add a marketing page