-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Add the Joy UI marketing page #36829
Conversation
Netlify deploy previewhttps://deploy-preview-36829--material-ui.netlify.app/ Bundle size report |
f60a5b9
to
40275f3
Compare
@danilo-leal pushed these changes:
|
Joy UI is for those that appreciate the comprehensiveness and reliability of Material | ||
UI, but don't want Material Design. It's design agnostic and built to be | ||
tailored to your specific design language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should avoid all mention of Material UI and Material Design here in the hero section. That can come later. We should use the opportunity to describe what it is more than what it's not. What are the top two or three key value propositions worth highlighting here? "Joy UI is great because..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, yeah! Meta note: Every piece of copy we're using on the page at the moment is either what we iterated on while the page was still in the Figma stage or place-holder stuff I came up with — so, taking advantage of this comment to extend the invite to revise the entire page's copywriting! 🤙 Some comments about specific parts were already dropped, and I'd like to get your take on them (click on the "Load more" up there a few times to see the previous thread 😬).
For this comment specifically, though, I'd likely highlight these aspects: 1) UI design (minimal, sleek, lightly opinionated); 2) customization UX (CSS variables, automatic features, etc.); 3) either DX (which can be covered in the previous topic) or breadth of components. Not fully sure about the third...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More random feedback, mostly on the copy, which I appreciate was always a WIP.
<GradientText>beautiful components and DX</GradientText> | ||
</Typography> | ||
} | ||
description="Joy UI components were extracted from Material UI, featuring the same robust engineering, and quickly trusted by many community members." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if developers might be concerned that Joy UI has inherited Material Design specific code baggage? Perhaps we could refer to it more obliquely?:
description="Joy UI components were extracted from Material UI, featuring the same robust engineering, and quickly trusted by many community members." | |
description="Joy UI components are built on the same robust engineering foundations as Material UI that are trusted by our growing community." |
(or some such)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, reading it again, this doesn't really follow from the H2 content of "beautiful components and DX"...
icon: <AccessibilityNewRounded fontSize="small" color="primary" />, | ||
title: 'Accessibility', | ||
description: | ||
'Joy UI is built off of from Base UI, which delivers several built-in accessibility features.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correcting the grammar:
'Joy UI is built off of from Base UI, which delivers several built-in accessibility features.', | |
'Joy UI is built with Base UI, which delivers several built-in accessibility features.', |
However "several built-in accessibility features" doesn't sound like we have given much attention to accessibility. Would it be fair to word this more strongly, or is that actually the case?
icon: <HandymanRoundedIcon fontSize="small" color="primary" />, | ||
title: 'Highly customizable', | ||
description: | ||
'Complete control over how the component looks, powered by several customization tools.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Complete control over how the component looks, powered by several customization tools.', | |
'Complete control over how the component looks, powered by several customization features.', |
icon: <InvertColorsRoundedIcon fontSize="small" color="primary" />, | ||
title: 'Beautiful out of the box', | ||
description: | ||
'Start looking good with very little effort. Joy UI is designed to be simple and agnostic.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty of editing @danilo-leal's sugestion.
title: 'Beautiful out of the box', | ||
description: | ||
'Start looking good with very little effort. Joy UI is designed to be simple and agnostic.', | ||
link: '/joy-ui/getting-started/#beautiful-out-of-the-box/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hash fragment links don't seem to be working for some reason.
Enhance your <GradientText>design workflow</GradientText> | ||
</Typography> | ||
} | ||
description="The Design kits contain many of the Material UI components with states, variations, colors, typography, and icons. We frequently update it to sync with the most up-to-date release." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description="The Design kits contain many of the Material UI components with states, variations, colors, typography, and icons. We frequently update it to sync with the most up-to-date release." | |
description="The Design kits contain many of the Material UI components with states, variations, colors, typography, and icons. We frequently update it to keep in sync with the latest release of Joy UI." |
import Frame from 'docs/src/components/action/Frame'; | ||
import Link from 'docs/src/modules/components/Link'; | ||
|
||
const DEMOS = ['Color & Typography', 'Components', 'Variants']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I misunderstanding, or are the demos for these reversed? 'Color & Typography' seems to show screenshots for Components, and vice versa.
} | ||
/> | ||
<GetStartedButtons | ||
primaryUrl={ROUTES.joyDocs} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this section is about Community should we be linking to perhaps Discord and Github instead?
title={ | ||
<Typography variant="h2" sx={{ mt: 1, maxWidth: 600, mx: 'auto' }}> | ||
Kick-start your new product with <br /> | ||
<GradientText>beautiful components and DX</GradientText> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<GradientText>beautiful components and DX</GradientText> | |
<GradientText>beautiful components and great DX</GradientText> |
Oops! This popped up on my "participating" notifications for some reason, so I thought it must still be being worked on, but I see there hasn't been any activity for a while, so I'm guess it's on-hold (for obvious reasons). Please disregard for now. |
I'll leave this PR closed as we're pausing it for now! We can always re-open it. :) |
To-do refinements
Pre-review batch of to-dos