Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs][base] Drop component prop #36770

Merged
merged 10 commits into from
Apr 28, 2023
Merged

[Tabs][base] Drop component prop #36770

merged 10 commits into from
Apr 28, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Apr 3, 2023 •
edited
Loading

part of #36679

https://deploy-preview-36770--material-ui.netlify.app/base/react-tabs/#usage-with-typescript

BREAKING CHANGE

It will be covered by codemod, see #36831

For Base UI components, the component prop value should be moved to slots.root:

 <Tabs
-  component="span"
+  slots={{ root: "span" }}
 />

If using TypeScript, you should add the custom component type as a generic on the Tabs component.

-<Tabs
+<Tabs<typeof CustomComponent>
   slots={{ root: CustomComponent }}
   customProp="foo"
 />

@sai6855 sai6855 added breaking change component: tabs This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Apr 3, 2023
@mui-bot
Copy link

mui-bot commented Apr 3, 2023 •
edited
Loading

Netlify deploy preview

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 455d06a

@sai6855 sai6855 changed the title [TabsUnstyled][Base] Drop component prop [TabsUnstyled] Drop component prop Apr 3, 2023
@sai6855 sai6855 requested a review from mnajdova April 3, 2023 17:24
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 11, 2023
@sai6855 sai6855 marked this pull request as draft April 12, 2023 15:04
@sai6855 sai6855 closed this Apr 26, 2023
@sai6855 sai6855 force-pushed the drop-component-tabs branch from 9e1b8b1 to 9118505 Compare April 26, 2023 14:03
@sai6855 sai6855 reopened this Apr 26, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 26, 2023
@sai6855 sai6855 marked this pull request as ready for review April 26, 2023 14:43
@sai6855 sai6855 requested a review from hbjORbj April 26, 2023 14:48
@hbjORbj hbjORbj mentioned this pull request Apr 27, 2023
Closed
19 tasks
@hbjORbj hbjORbj changed the title [TabsUnstyled] Drop component prop [Tabs][base] Drop component prop Apr 28, 2023
@hbjORbj hbjORbj merged commit c7be514 into mui:master Apr 28, 2023
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@sai6855 @binh1298
[Tabs][base] Drop component prop (mui#36770)
6d2bf2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
breaking change component: tabs This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sai6855 @mui-bot @hbjORbj