[Slider] onChange handler should be called only when value has changed
#36706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: seunexplicit <[email protected]>
Netlify deploy previewhttps://deploy-preview-36706--material-ui.netlify.app/ Bundle size report |
Co-authored-by: seunexplicit <[email protected]>
mnajdova
reviewed
Apr 12, 2023
| @@ -224,6 +224,12 @@ export default function useSlider(parameters: UseSliderParameters): UseSliderRet | |||
| name: 'Slider', | |||
| }); | |||
|
|
|||
| const isValueUnchanged = (newValue: number | Array<number>): boolean => { | |||
There was a problem hiding this comment.
Suggested change
| const isValueUnchanged = (newValue: number | Array<number>): boolean => { | |
| const areValuesEqual = (oldValue: number | Array<number>, newValue: number | Array<number>): boolean => { |
Let's rename the util, it has negation in the name, and we use another negation when invoking. Also, let's change the signature and move it outside of the component.
There was a problem hiding this comment.
This has been implemented, please check again.
Thanks for the suggestion @mnajdova, the tests are passing now. |
zannager
added
the
component: slider
ZeeshanTamboli
changed the title
Co-authored-by: seunexplicit <[email protected]>
2 tasks
Co-authored-by: seunexplicit <[email protected]>
|
@ZeeshanTamboli your comments have been implemented, please check again. |
ZeeshanTamboli
approved these changes
Apr 20, 2023
ZeeshanTamboli
changed the title
onChange handler should be called only when value has changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing handleChange being called even when value remains the same.
Closes #36614
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.