-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Add Base UI marketing page #36622
Conversation
Netlify deploy previewhttps://deploy-preview-36622--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danilo-leal I Need some clarification on the new font so that we can optimize them similar to what I did with PlusJarkarta, the rest looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danilo-leal The font flash is fixed (I did it for IBM Plex Sans regular as well). I can't approve my PR so feel free to merge when you think it is ready.
Sweet, these are all good points!
Just reiterating that given the merge of this PR and the marketing/promotion of the page are separate things, don't think these points are blockers! We should for sure iterate/work on them following the merge 🤙 And for the sake of alignment, we agreed on merging this PR as it houses a bunch of general style updates to the website/documentation and to hold on to the actual Base UI page promotion until possibly the end of the northern hemisphere summer to potentially bundle it up with the Joy UI stable. @mnajdova let me know if all of this makes sense and if you think it's ready to go! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to get this one out! 🎉
It's awesome to have this page 🎉 A review on the page: https://mui.com/base-ui/. Opportunities we could use to improve it. I'm adding @zanivan to the loop as this can often be applied to the core in general. Here is what I think would move us to state-of-the-art.
Screen.Recording.2023-07-21.at.00.07.14.mov
![]() In the doubt, I think using the same one as Joy UI would make sense.
![]()
Screen.Recording.2023-07-20.at.23.29.45.movI haven't seen any other libraries do this, but it's so smooth (click jump https://m2.material.io/components/sliders#discrete-sliders)
![]()
![]()
![]()
![]()
Screen.Recording.2023-07-21.at.00.21.56.movThis is a bug with Joy UI and Material UI as well.
![]()
Correct ![]() Wrong ![]()
Screen.Recording.2023-07-20.at.23.52.34.movMaterial UI, I would argue that when the button is a Screen.Recording.2023-07-21.at.01.39.03.movRelated to whatwg/html#8228 Enjoy 😁 |
@oliviertassinari sweet, appreciate the thorough & detailed feedback! 😬 Two clarifying questions, though:
|
|
Actually on 13. it directly connects to a UX pain on the page. In the beginning of the video, I have no idea of the copy click feature, I just want to copy the text, I can't. Then, in the second part of the video, I remove the Screen.Recording.2023-07-23.at.02.05.15.movI think they do it right: Screen.Recording.2023-07-23.at.02.07.04.mov |
Created #38158 to address point 13. In Firefox, the button text will still be not selectable, as that's their default (check https://nextjs.org/ on that browser). |
Once we complet the round of polish on the marketing page, I think that we can announce it on Twitter, it will make for a great content, e.g. https://twitter.com/colmtuite/status/1453021328274034694. |
Introducing Base UI as a stable product within the MUI Core line.
https://deploy-preview-36622--material-ui.netlify.app/base-ui/
Landing page tasks
Tangential tasks