Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joy-ui][docs] Revise the Lists page #36324

Merged
merged 18 commits into from
Sep 5, 2023
Merged

[joy-ui][docs] Revise the Lists page #36324

merged 18 commits into from
Sep 5, 2023

Conversation

LadyBluenotes
Copy link
Contributor

@LadyBluenotes LadyBluenotes commented Feb 24, 2023 •
edited by mapache-salvaje
Loading

Part of #33998

Hello hello @samuelsycamore, I hope your day is treating you well!

I decided to get started on another doc page. Here's hoping all the previous comments have improved my edits 🥲

Let me know how I can make it better!

@mui-bot
Copy link

mui-bot commented Feb 24, 2023 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9541a81

@LadyBluenotes
Copy link
Contributor Author

LadyBluenotes commented Feb 24, 2023 •
edited
Loading

Not sure why the test_static didn't work but I'll run that again

@zannager zannager added the docs Improvements or additions to the documentation label Feb 27, 2023
@zannager zannager requested a review from siriwatknp February 27, 2023 10:18
@mapache-salvaje mapache-salvaje added component: list This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Mar 9, 2023
@mapache-salvaje
Copy link
Contributor

Hey @LadyBluenotes ! Sorry it's taken me so long to circle back to this.

According to ci/circleci: test_static, it looks like you need to run yarn docs:link-check to find and fix broken links—that's why it's failing.

@LadyBluenotes
Copy link
Contributor Author

Errors were fixed with the last run 👍🏼

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 15, 2023
@LadyBluenotes
Copy link
Contributor Author

Hey just wondering if there was anything I needed to do for this!

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Mar 27, 2023
@mapache-salvaje mapache-salvaje mentioned this pull request Apr 5, 2023
Closed
61 tasks
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 5, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 29, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 3, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 23, 2023
@danilo-leal danilo-leal changed the title [docs] Revise Joy UI "Lists" page [joy-ui][docs] Revise the Lists page Aug 29, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 29, 2023
danilo-leal
danilo-leal approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🤙

@mapache-salvaje
Copy link
Contributor

I think this is pretty much good to go, but let me do one final copyediting pass before we merge it.

@mapache-salvaje
Copy link
Contributor

99% done, just need to flesh out the Anatomy section to include the whole suite of components here!

@mapache-salvaje
Copy link
Contributor

I think this is ready to go if @danilo-leal or @siriwatknp could give it one last look!

danilo-leal
danilo-leal approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one! 🤘

@mapache-salvaje
Copy link
Contributor

Thanks to @LadyBluenotes for getting the ball rolling here in the first place! Sarah, I apologize that this fell by the wayside as I had to prioritize other projects over the last several months. We're starting to do more content editing and revisions on the Joy UI and Base UI docs as we prepare for stable releases, and I'd be happy to have you contributing again if you're interested. Just lemme know!

@mapache-salvaje mapache-salvaje merged commit ab1c307 into mui:master Sep 5, 2023
@LadyBluenotes
Copy link
Contributor Author

@samuelsycamore Hey Sam! Completely understandable :) I would love to help with the editing / revisions. Let me know how I can best support you :)

mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@LadyBluenotes @siriwatknp
@mapache-salvaje @danilo-leal @mnajdova
[joy-ui][docs] Revise the Lists page (mui#36324)
e5bfd6d 
Signed-off-by: Siriwat K <[email protected]>
Signed-off-by: Danilo Leal <[email protected]>
Co-authored-by: siriwatknp <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Co-authored-by: Danilo Leal <[email protected]>
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@LadyBluenotes @siriwatknp
@mapache-salvaje @danilo-leal @mnajdova
[joy-ui][docs] Revise the Lists page (mui#36324)
71b5544 
Signed-off-by: Siriwat K <[email protected]>
Signed-off-by: Danilo Leal <[email protected]>
Co-authored-by: siriwatknp <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Co-authored-by: Danilo Leal <[email protected]>
xcode-it pushed a commit to xcode-it/material-ui that referenced this pull request Sep 11, 2023
@LadyBluenotes @siriwatknp
@mapache-salvaje @danilo-leal @xcode-it
[joy-ui][docs] Revise the Lists page (mui#36324)
dc00fcf 
Signed-off-by: Siriwat K <[email protected]>
Signed-off-by: Danilo Leal <[email protected]>
Co-authored-by: siriwatknp <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Co-authored-by: Danilo Leal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp left review comments

@danilo-leal danilo-leal danilo-leal approved these changes

@mapache-salvaje mapache-salvaje Awaiting requested review from mapache-salvaje

Assignees
No one assigned
Labels
component: list This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
Joy UI
Status: Recently completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LadyBluenotes @mui-bot @mapache-salvaje @siriwatknp @danilo-leal @zannager