Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[useSnackbar] Add explicit return type #36052

Merged
merged 10 commits into from
Mar 6, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Feb 4, 2023

useSnackBar return value interface

closes useSnackBar in #35933

preview: https://deploy-preview-36052--material-ui.netlify.app/base/api/use-snackbar/#return-value

@mui-bot
Copy link

mui-bot commented Feb 4, 2023

Netlify deploy preview

https://deploy-preview-36052--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against ffc4894

@zannager zannager added the component: snackbar This is the name of the generic UI component, not the React module! label Feb 6, 2023
@zannager zannager requested a review from mnajdova February 6, 2023 11:29
@sai6855 sai6855 requested a review from mnajdova February 8, 2023 17:29
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 21, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 25, 2023
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@ZeeshanTamboli ZeeshanTamboli merged commit d3ce75a into mui:master Mar 6, 2023
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Mar 6, 2023
1 task
@ZeeshanTamboli ZeeshanTamboli changed the title [useSnackBar] Add explicit return type [useSnackbar] Add explicit return type Mar 6, 2023
@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation typescript labels Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: snackbar This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants