Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Card] Add callback signature to property docs #3552

Merged
merged 1 commit into from
Mar 2, 2016
Merged

[Card] Add callback signature to property docs #3552

merged 1 commit into from
Mar 2, 2016

Conversation

theosherry
Copy link
Contributor

Hey, PR towards closing #3096

@mbrookes mbrookes changed the title [Docs] Added callback signature for Card documentation [Docs] Add callback signature for Card documentation Mar 2, 2016
@mbrookes mbrookes changed the title [Docs] Add callback signature for Card documentation [Docs] Add callback signature for Card Mar 2, 2016
@mbrookes mbrookes changed the title [Docs] Add callback signature for Card [Card] Add callback signature to property docs Mar 2, 2016
@mbrookes mbrookes added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Mar 2, 2016
@mbrookes
Copy link
Member

mbrookes commented Mar 2, 2016

Sorry to keep changing the title. I changed it then remembered a discussion about PR & Commit naming for tests, and we've agreed to follow the same pattern for docs updates (updates to docs for a particular component are named for the component, updates to the docs core (or across multiple components) are named '[Docs] ...') - so I've changed it again!

If you could change the PR title to match we can merge this. 👍

@mbrookes mbrookes self-assigned this Mar 2, 2016
@theosherry
Copy link
Contributor Author

Ah ok. I've updated the commit message, and I'll use that format for future PRs. Thanks!

@mbrookes mbrookes added PR: Review Accepted and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Mar 2, 2016
@mbrookes
Copy link
Member

mbrookes commented Mar 2, 2016

Thanks! 👍 Could you do #3550 too?

@theosherry
Copy link
Contributor Author

Ok I corrected #3550

@alitaheri
Copy link
Member

Thanks a lot @theosherry 👍

alitaheri added a commit that referenced this pull request Mar 2, 2016
[Card] Add callback signature to property docs
@alitaheri alitaheri merged commit 0e53480 into mui:master Mar 2, 2016
mbradleyis pushed a commit to staticinstance/material-ui that referenced this pull request Mar 7, 2016
[Card] Add callback signature to property docs
@zannager zannager added the component: card This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: card This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants