[CardTitle] remove title from injected node attributes (to avoid native tooltip)
#3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return ( | ||
| <div {...this.props} style={prepareStyles(rootStyle)}> | ||
| <div {...attrs} style={prepareStyles(rootStyle)}> | ||
| <span style={prepareStyles(titleStyle)}> | ||
| {this.props.title} | ||
| </span> |
There was a problem hiding this comment.
Would this work?
const {title, ...other} = this.props;
return (
<div {...other} style={prepareStyles(rootStyle)}>
<span style={prepareStyles(titleStyle)}>
{title}
</span>There was a problem hiding this comment.
nicer indeed! didn't know I could already use this ES7 bit :)
There was a problem hiding this comment.
JSX has implemented it: https://facebook.github.io/react/docs/transferring-props.html#transferring-with-...-in-jsx
| @@ -79,13 +79,15 @@ const CardTitle = React.createClass({ | |||
| const titleStyle = Object.assign({}, styles.title, this.props.titleStyle); | |||
| const subtitleStyle = Object.assign({}, styles.subtitle, this.props.subtitleStyle); | |||
|
|
|||
| const {title, subtitle, ...attrs} = this.props; | |||
There was a problem hiding this comment.
Could we follow the other components?
const {
title,
subtitle,
...other,
} = this.props;
4 tasks
|
Looks good, thanks @antoinerousseau! |
newoga
added a commit
that referenced
this pull request
Mar 2, 2016
[CardTitle] remove `title` from injected node attributes (to avoid native tooltip)
mbradleyis
pushed a commit
to staticinstance/material-ui
that referenced
this pull request
Mar 7, 2016
[CardTitle] remove `title` from injected node attributes (to avoid native tooltip)
zannager
added
the
component: card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2894.