[docs] Fix ad margin on API pages #35201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
|
oliviertassinari
force-pushed
the
docs-fix-ad-margin
branch
2 times, most recently
from
4b03e6f to
7c03e8e
Compare
oliviertassinari
added
regression
siriwatknp
approved these changes
Nov 25, 2022
|
I will see if we need to apply the same fix in MUI X, I suspect that they duplicate the file, so the fix won't propagate automatically. It's broken right now https://mui.com/x/api/data-grid/data-grid-pro/. |
This was referenced Nov 30, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug:
https://mui.com/material-ui/api/dialog/
The root of the problem is that
AdGuestuse the DOM API to add theadclass name once the Ad component is portaled but on this page, we don't usedangerouslySetInnerHTMLto render the markdown, we use the React API directly.I could pinpoint the origin of the change of behavior to the v5.9.0 release. This release includes #33196, so very likely the origin.
MUI X https://github.com/mui/mui-x/blob/c8f112caed7bd50fb1ba723f7db47590d08d926b/docs/src/modules/components/ApiDocs.js duplicate this file, so I will need to apply the same fix there too, not ideal but no other choices.
Preview: https://deploy-preview-35201--material-ui.netlify.app/material-ui/api/dialog/