Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System] Calls unstable_createStyleFunctionSx with passed in arg #35008

Conversation

CalebJamesStevens
Copy link

@CalebJamesStevens CalebJamesStevens commented Nov 5, 2022

What does this fix

The purpose of this PR is to fix compatibility issues with turbopack for next.js 13. The issue can be found in this open issue

Fixes #34910

What changes were made to fix this

For uknown reasons unstable_createStyleFunctionSx on line 98 was not able to grab the import to use as a default on its own when ran with turbopack bundler causing a reference error shown in git issue link above

@CalebJamesStevens CalebJamesStevens changed the title Calls unstable_createStyleFunctionSx with direct import Calls unstable_createStyleFunctionSx with passed in arg Nov 5, 2022
@mui-bot
Copy link

mui-bot commented Nov 5, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35008--material-ui.netlify.app/

Details of bundle changes

Generated by 🚫 dangerJS against f431097

@CalebJamesStevens CalebJamesStevens changed the title Calls unstable_createStyleFunctionSx with passed in arg [System] Calls unstable_createStyleFunctionSx with passed in arg Nov 5, 2022
@CalebJamesStevens
Copy link
Author

I don't know how to add a label i'm sorry. Been looking for a long time now and i'm getting tired.

@Duoquote
Copy link

Duoquote commented Nov 5, 2022

Any updates on this?

@CalebJamesStevens
Copy link
Author

Any updates on this?

Made the PR last night but don't know how to add labels to the PR so idk if they'll even look at it

@zannager zannager added the package: system Specific to @mui/system label Nov 7, 2022
@zannager zannager requested a review from siriwatknp November 7, 2022 09:12
@Kliton
Copy link

Kliton commented Nov 7, 2022

Any update?

@CalebJamesStevens
Copy link
Author

Any update?

Still waiting, soon possibly

@CalebJamesStevens
Copy link
Author

Anyone going to review this...?

@mnajdova
Copy link
Member

mnajdova commented Nov 10, 2022

For uknown reasons unstable_createStyleFunctionSx on line 98 was not able to grab the import to use as a default on its own when ran with turbopack bundler causing a reference error shown in git issue link above

We should work on finding out the reason for this. I don't think it's related to MUI, or at least it's not clear why it happens on this specific import. Note that the turbopack is still in alpha, so creating an issue on their repo is more likely to guide us to the reason of why this happens. I can't imagine lots of library changing their code, just because some import is not picked up by turbopack.

I am mainly saying this, because we could write a similar code tomorrow, that would break the build again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js 13 Error during SSR Rendering ReferenceError: defaultStyleFunctionMapping is not defined
6 participants