[OptionUnstyled] Define ownerState and slot props' types #32717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
component: select
|
@material-ui/unstyled: parsed: -13.21% 😍, gzip: -9.20% 😍 |
mnajdova
reviewed
May 13, 2022
| @@ -41,3 +41,19 @@ export default interface OptionGroupUnstyledProps { | |||
| list?: React.ComponentPropsWithRef<'ul'> & OptionGroupUnstyledComponentsPropsOverrides; | |||
| }; | |||
| } | |||
|
|
|||
| export type OptionGroupUnstyledRootSlotProps = { | |||
There was a problem hiding this comment.
I was surprised at first that we don't have here ownerState, but saw later that we indeed don't have it for simple components :) I guess having the correct types will be helpful for developers :)
There was a problem hiding this comment.
If developers complain about not having it, we may define type OptionGroupUnstyledOwnerState = OptionGroupUnstyledProps, and pass it to the slots, but I don't think it's necessary now.
mnajdova
approved these changes
May 13, 2022
frankkluijtmans
pushed a commit
to frankkluijtmans/material-ui
that referenced
this pull request
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defined types for slots of OptionUnstyled and OptionGroupUnstyled